Changeset 7043

Timestamp:

01/28/08 08:27:53 (6 months ago)

Author:

mtredinnick

Message:

queryset-refactor: Added an update method to QuerySets?, since it's needed for
moving SQL out of the core code. Only direct fields and foreign keys can be
updated in this fashion, since multi-table updates are very non-portable.

This also cleans up the API for the UpdateQuery? class a bit. Still need to
change DeleteQuery? to work similarly, I suspect.

Refs #4260.

Files:

• django/branches/queryset-refactor/django/db/models/query.py (modified) (1 diff)
• django/branches/queryset-refactor/django/db/models/sql/query.py (modified) (4 diffs)
• django/branches/queryset-refactor/docs/db-api.txt (modified) (1 diff)
• django/branches/queryset-refactor/tests/modeltests/update (added)
• django/branches/queryset-refactor/tests/modeltests/update/__init__.py (added)
• django/branches/queryset-refactor/tests/modeltests/update/models.py (added)

django/branches/queryset-refactor/django/db/models/query.py

@@ -255 +255 @@
-        self._result_cache = None
-    delete.alters_data = True
+
+    def update(self, **kwargs):
+        """
+        Updates all elements in the current QuerySet, setting all the given
+        fields to the appropriate values.
+        """
+        query = self.query.clone(sql.UpdateQuery)
+        query.add_update_values(kwargs)
+        query.execute_sql(None)
+        self._result_cache=None
+    update.alters_Data = True
-
-    ##################################################

django/branches/queryset-refactor/django/db/models/sql/query.py

@@ -175 +175 @@
-        obj.extra_order_by = self.extra_order_by[:]
-        obj.__dict__.update(kwargs)
+        if hasattr(obj, '_setup_query'):
+            obj._setup_query()
-        return obj
-
@@ -1160 +1162 @@
-    def __init__(self, *args, **kwargs):
-        super(UpdateQuery, self).__init__(*args, **kwargs)
+        self._setup_query()
+
+    def _setup_query(self):
+        """
+        Run on initialisation and after cloning.
+        """
-        self.values = []
-
@@ -1167 +1175 @@
-        parameters.
-        """
-
-
+
+
+
+
-        result = ['UPDATE %s' % self.tables[0]]
-        result.append('SET')
-        qn = self.quote_name_unless_alias
-
+
+
+
+
+
+
+
-        result.append(', '.join(values))
-        where, params = self.where.as_sql()
-        result.append('WHERE %s' % where)
-
-
-
-
-
-
-
+
-
-    def clear_related(self, related_field, pk_list):
@@ -1192 +1202 @@
-        """
-        for offset in range(0, len(pk_list), GET_ITERATOR_CHUNK_SIZE):
-
+self.
-            f = self.model._meta.pk
-
+self.
-                    pk_list[offset : offset + GET_ITERATOR_CHUNK_SIZE]),
-                    AND)
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
-
-class DateQuery(Query):

django/branches/queryset-refactor/docs/db-api.txt

@@ -1973 +1973 @@
-    Entry.objects.all().delete()
-
+Updating multiple objects at once
+=================================
+
+**New in Django development version**
+
+Sometimes you want to set a field to a particular value for all the objects in
+a queryset. You can do this with the ``update()`` method. For example::
+
+    # Update all the headlings to the same value.
+    Entry.objects.all().update(headline='Everything is the same')
+
+You can only set non-relation fields and ``ForeignKey`` fields using this
+method and the value you set the field to must be a normal Python value (you
+can't set a field to be equal to some other field at the moment).
+
+To update ``ForeignKey`` fields, set the new value to be the new model
+instance you want to point to. Example::
+
+    b = Blog.objects.get(pk=1)
+    # Make all entries belong to this blog.
+    Entry.objects.all().update(blog=b)
+
+The ``update()`` method is applied instantly and doesn't return anything
+(similar to ``delete()``). The only restriction on the queryset that is
+updated is that it can only access one database table, the model's main
+table. So don't try to filter based on related fields or anything like that;
+it won't work.
+
-Extra instance methods
-======================