Changeset 6869

Timestamp:

12/03/07 15:23:15 (9 months ago)

Author:

mtredinnick

Message:

queryset-refactor: Added a FIXME for something I just remembered.

Files:

• django/branches/queryset-refactor/django/db/models/sql/query.py (modified) (1 diff)

django/branches/queryset-refactor/django/db/models/sql/query.py

@@ -739 +739 @@
-                if join == table and self.alias_map[join][ALIAS_REFCOUNT] > 1:
-                    continue
+                # FIXME: Don't have to promote here (and in the other places in
+                # this block) if the join isn't nullable. So I should be
+                # checking this before promoting (avoiding left outer joins is
+                # important).
-                self.promote_alias(join)
-                if table != join: