Django

Code

Changeset 6780

Show
Ignore:
Timestamp:
11/30/07 12:28:19 (10 months ago)
Author:
mtredinnick
Message:

Fixed some type checks in the development server. Fixed #6063.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • django/trunk/django/core/servers/basehttp.py

    r6634 r6780  
    99 
    1010from BaseHTTPServer import BaseHTTPRequestHandler, HTTPServer 
    11 from types import ListType, StringType 
    1211import mimetypes 
    1312import os 
     
    7372    """Manage a collection of HTTP response headers""" 
    7473    def __init__(self,headers): 
    75         if type(headers) is not ListType
     74        if not isinstance(headers, list)
    7675            raise TypeError("Headers must be a list of name/value tuples") 
    7776        self._headers = headers 
     
    328327        try: 
    329328            blocks = len(self.result) 
    330         except (TypeError,AttributeError,NotImplementedError): 
     329        except (TypeError, AttributeError, NotImplementedError): 
    331330            pass 
    332331        else: 
     
    357356            raise AssertionError("Headers already set!") 
    358357 
    359         assert type(status) is StringType,"Status must be a string" 
     358        assert isinstance(status, str),"Status must be a string" 
    360359        assert len(status)>=4,"Status must be at least 4 characters" 
    361360        assert int(status[:3]),"Status message must begin w/3-digit code" 
     
    363362        if __debug__: 
    364363            for name,val in headers: 
    365                 assert type(name) is StringType,"Header names must be strings" 
    366                 assert type(val) is StringType,"Header values must be strings" 
     364                assert isinstance(name, str),"Header names must be strings" 
     365                assert isinstance(val, str),"Header values must be strings" 
    367366                assert not is_hop_by_hop(name),"Hop-by-hop headers not allowed" 
    368367        self.status = status 
     
    387386        """'write()' callable as specified by PEP 333""" 
    388387 
    389         assert type(data) is StringType,"write() argument must be string" 
     388        assert isinstance(data, str), "write() argument must be string" 
    390389 
    391390        if not self.status: