Changeset 6745

Timestamp:

11/29/07 13:22:03 (11 months ago)

Author:

mtredinnick

Message:

Fixed #5959 -- Fixed handling of False values in hidden boolean fields. Thanks,
SmileyChris?.

Files:

• django/trunk/django/newforms/fields.py (modified) (1 diff)
• django/trunk/tests/regressiontests/forms/fields.py (modified) (2 diffs)
• django/trunk/tests/regressiontests/forms/widgets.py (modified) (1 diff)

django/trunk/django/newforms/fields.py

@@ -537 +537 @@
-
-    def clean(self, value):
-Returns a Python boolean object.
+""Returns a Python boolean object.""
-        super(BooleanField, self).clean(value)
-
-
-
+
+
+
+
-            return False
-        return bool(value)

django/trunk/tests/regressiontests/forms/fields.py

@@ -915 +915 @@
-True
-
+>>> f.clean('True')
+True
+>>> f.clean('False')
+False
+
->>> f = BooleanField(required=False)
->>> f.clean('')
@@ -930 +935 @@
->>> f.clean('Django rocks')
-True
+
+A form's BooleanField with a hidden widget will output the string 'False', so
+that should clean to the boolean value False:
+>>> f.clean('False')
+False
-
-# ChoiceField #################################################################

django/trunk/tests/regressiontests/forms/widgets.py

@@ -129 +129 @@
->>> w.render('email', '', attrs={'class': 'special'})
-u'<input type="hidden" class="special" name="email" />'
+
+Boolean values are rendered to their string forms ("True" and "False").
+>>> w = HiddenInput()
+>>> w.render('get_spam', False)
+u'<input type="hidden" name="get_spam" value="False" />'
+>>> w.render('get_spam', True)
+u'<input type="hidden" name="get_spam" value="True" />'
-
-# MultipleHiddenInput Widget ##################################################