Changeset 6600

Timestamp:

10/23/07 08:49:07 (9 months ago)

Author:

mtredinnick

Message:

queryset-refactor: Added a convenience all() method to Querysets. Refs #3739

Files:

• django/branches/queryset-refactor/django/db/models/query.py (modified) (1 diff)
• django/branches/queryset-refactor/docs/db-api.txt (modified) (1 diff)
• django/branches/queryset-refactor/tests/regressiontests/queries/models.py (modified) (1 diff)

django/branches/queryset-refactor/django/db/models/query.py

@@ -246 +246 @@
-    # PUBLIC METHODS THAT ALTER ATTRIBUTES AND RETURN A NEW QUERYSET #
-    ##################################################################
+
+    def all(self):
+        """
+        Returns a new QuerySet that is a copy of the current one. This allows a
+        QuerySet to proxy for a model manager in some cases.
+        """
+        return self._clone()
-
-    def filter(self, *args, **kwargs):

django/branches/queryset-refactor/docs/db-api.txt

@@ -682 +682 @@
-    []
-
+``all()``
+~~~~~~~~~~
+
+**New in Django development version**
+
+Returns a ''copy'' of the current ``QuerySet`` (or ``QuerySet`` subclass you
+pass in). This can be useful in some situations where you might want to pass
+in either a model manager or a ``QuerySet`` and do further filtering on the
+result. You can safely call ``all()`` on either object and then you'll
+definitely have a ``QuerySet`` to work with.
+
-``select_related()``
-~~~~~~~~~~~~~~~~~~~~

django/branches/queryset-refactor/tests/regressiontests/queries/models.py

@@ -375 +375 @@
-[]
-
+Bug #3739
+The all() method on querysets returns a copy of the queryset.
+>>> q1 = Item.objects.order_by('name')
+>>> id(q1) == id(q1.all())
+False
-"""}
-