Changeset 6563

Timestamp:

10/20/07 07:21:07 (11 months ago)

Author:

mtredinnick

Message:

Changed newforms.CheckboxInput? widget to return False as its value when not
include in the form (since HTML form submission doesn't send unselected check
boxes). Patch from SmileyChris?. Refs #5104.

Files:

• django/trunk/django/newforms/widgets.py (modified) (1 diff)
• django/trunk/tests/regressiontests/forms/widgets.py (modified) (1 diff)

django/trunk/django/newforms/widgets.py

@@ -170 +170 @@
-            final_attrs['value'] = force_unicode(value) # Only add the 'value' attribute if a value is non-empty.
-        return u'<input%s />' % flatatt(final_attrs)
+
+    def value_from_datadict(self, data, files, name):
+        if name not in data:
+            # A missing value means False because HTML form submission does not
+            # send results for unselected checkboxes.
+            return False
+        return super(CheckboxInput, self).value_from_datadict(data, files, name)
-
-class Select(Widget):

django/trunk/tests/regressiontests/forms/widgets.py

@@ -276 +276 @@
->>> w.render('greeting', None)
-u'<input type="checkbox" name="greeting" />'
+
+The CheckboxInput widget will return False if the key is not found in the data
+dictionary (because HTML form submission doesn't send any result for unchecked
+checkboxes).
+>>> w.value_from_datadict({}, {}, 'testing')
+False
-
-# Select Widget ###############################################################