Changeset 5882

Timestamp:

08/13/07 16:42:37 (1 year ago)

Author:

adrian

Message:

Fixed #5030 -- Removed 'COUNT()' from Model.save() when determining whether a row exists. We're now using a SELECT 1 LIMIT 1 instead, as it's more efficient in some databases. Thanks, zigiDev@mac.com and the various folks who verified this patch works

Files:

• django/trunk/django/db/models/base.py (modified) (1 diff)

django/trunk/django/db/models/base.py

@@ -214 +214 @@
-        if pk_set:
-            # Determine whether a record with the primary key already exists.
-COUNT(*) FROM %s WHERE %s=%%s
+1 FROM %s WHERE %s=%%s LIMIT 1
-                (backend.quote_name(self._meta.db_table), backend.quote_name(self._meta.pk.column)),
-                self._meta.pk.get_db_prep_lookup('exact', pk_val))
-            # If it does already exist, do an UPDATE.
-[0] > 0
+
-                db_values = [f.get_db_prep_save(raw and getattr(self, f.attname) or f.pre_save(self, False)) for f in non_pks]
-                if db_values: