Changeset 5875

Timestamp:

08/12/07 07:29:25 (1 year ago)

Author:

mtredinnick

Message:

Fixed #4946 -- Added some small improvements to Gzip middleware. Thanks, colin@owlfish.com.

Files:

• django/trunk/django/middleware/gzip.py (modified) (1 diff)
• django/trunk/docs/middleware.txt (modified) (1 diff)

django/trunk/django/middleware/gzip.py

@@ -12 +12 @@
-    """
-    def process_response(self, request, response):
+        if response.status_code != 200 or len(response.content) < 200:
+            # Not worth compressing really short responses or 304 status
+            # responses, etc.
+            return response
+
-        patch_vary_headers(response, ('Accept-Encoding',))
-        

django/trunk/docs/middleware.txt

@@ -92 +92 @@
-browsers).
-
+It is suggested to place this first in the middleware list, so that the
+compression of the response content is the last thing that happens. Will not
+compress content bodies less than 200 bytes long, when the response code is
+something other than 200, Javascript files (for IE compatibitility), or
+responses that have the ``Content-Encoding`` header already specified.
+
-django.middleware.http.ConditionalGetMiddleware
------------------------------------------------