Changeset 5187

Timestamp:

05/11/07 03:22:06 (2 years ago)

Author:

mtredinnick

Message:

Fixed #4270 -- Don't permit deleting of items from an immutable QueryDict?.
Thanks, Gary Wilson.

Files:

• django/trunk/django/http/__init__.py (modified) (1 diff)
• django/trunk/tests/regressiontests/httpwrappers/tests.py (modified) (2 diffs)

django/trunk/django/http/__init__.py

@@ -92 +92 @@
-        MultiValueDict.__setitem__(self, key, value)
-
+    def __delitem__(self, key):
+        self._assert_mutable()
+        super(QueryDict, self).__delitem__(key)
+
-    def __copy__(self):
-        result = self.__class__('', mutable=True)

django/trunk/tests/regressiontests/httpwrappers/tests.py

@@ -97 +97 @@
-'john'
-
+>>> del q['name']
+>>> 'name' in q
+False
+
+>>> q['name'] = 'john'
+
->>> q.get('foo', 'default')
-'default'
@@ -368 +374 @@
-'vote=yes&vote=no'
-
+>>> del q['vote']
+Traceback (most recent call last):
+...
+AttributeError: This QueryDict instance is immutable
+
-"""
-