Django

Code

Changeset 5097

Show
Ignore:
Timestamp:
04/26/07 09:58:38 (2 years ago)
Author:
mtredinnick
Message:

Revert [5092], since this should only have been applied to newforms-admin.
Refs #1576.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • django/trunk/django/contrib/admin/views/main.py

    r5092 r5097  
    708708        # value in the related table. 
    709709        lookup_order_field = self.order_field 
    710         order_type = self.order_type == 'desc' and '-' or '' 
    711710        try: 
    712711            f = self.lookup_opts.get_field(self.order_field, many_to_many=False) 
     
    719718            elif isinstance(f.rel, models.ManyToOneRel): 
    720719                rel_ordering = f.rel.to._meta.ordering and f.rel.to._meta.ordering[0] or f.rel.to._meta.pk.column 
    721                 if rel_ordering[0] == '-': 
    722                     rel_ordering = rel_ordering[1:] 
    723                     order_type = not order_type and '-' or '' 
    724720                lookup_order_field = '%s.%s' % (f.rel.to._meta.db_table, rel_ordering) 
    725                 # Must select related because the lookup field may be in a 
    726                 # table not otherwise referenced yet. 
    727                 # FIXME: Try to remove the need for this in the QuerySet 
    728                 # refactor. 
    729                 qs = qs.select_related() 
    730721 
    731722        # Set ordering. 
    732         qs = qs.order_by('%s%s' % (order_type, lookup_order_field)
     723        qs = qs.order_by((self.order_type == 'desc' and '-' or '') + lookup_order_field
    733724 
    734725        # Apply keyword searches.