Changeset 4313

Timestamp:

01/12/07 23:19:15 (2 years ago)

Author:

adrian

Message:

Fixed #3281 -- newforms: URLField now works properly with required=False and verify_exists=True together. Thanks, zendak

Files:

• django/trunk/django/newforms/fields.py (modified) (1 diff)
• django/trunk/tests/regressiontests/forms/tests.py (modified) (1 diff)

django/trunk/django/newforms/fields.py

@@ -289 +289 @@
-    def clean(self, value):
-        value = RegexField.clean(self, value)
+        if not self.required and value == u'':
+            return value
-        if self.verify_exists:
-            import urllib2

django/trunk/tests/regressiontests/forms/tests.py

@@ -1332 +1332 @@
-...
-ValidationError: [u'This URL appears to be a broken link.']
+>>> f = URLField(verify_exists=True, required=False)
+>>> f.clean('')
+u''
+>>> f.clean('http://www.google.com') # This will fail if there's no Internet connection
+u'http://www.google.com'
-
-EmailField also access min_length and max_length parameters, for convenience.