Django

Code

Changeset 4312

Show
Ignore:
Timestamp:
01/12/07 23:08:07 (2 years ago)
Author:
adrian
Message:

Fixed #3293 -- newforms: Changed IntegerField?.clean() to return None if field is not required and empty. Thanks, Honza Kral

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • django/trunk/django/newforms/fields.py

    r4298 r4312  
    115115        """ 
    116116        Validates that int() can be called on the input. Returns the result 
    117         of int(). 
     117        of int(). Returns None for empty values. 
    118118        """ 
    119119        super(IntegerField, self).clean(value) 
    120120        if not self.required and value in EMPTY_VALUES: 
    121             return u'' 
     121            return None 
    122122        try: 
    123123            value = int(value) 
  • django/trunk/tests/regressiontests/forms/tests.py

    r4311 r4312  
    811811>>> f = IntegerField(required=False) 
    812812>>> f.clean('') 
    813 u'' 
     813>>> repr(f.clean('')) 
     814'None' 
    814815>>> f.clean(None) 
    815 u'' 
     816>>> repr(f.clean(None)) 
     817'None' 
    816818>>> f.clean('1') 
    8178191