Django

Code

Changeset 4191

Show
Ignore:
Timestamp:
12/10/06 19:24:33 (2 years ago)
Author:
adrian
Message:

Edited docs/contributing.txt changes from [4190]

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • django/trunk/docs/contributing.txt

    r4190 r4191  
    138138------------------- 
    139139 
    140 If a patch is non-trivial, there should be some evidence that there  
    141 has been discussion on `django-developers`_ of any alternatives.  
    142 Note that 'non-trivial' doesn't just mean 'only affects 1-2 lines 
    143 of code' - it also includes the fact that the lines that are being 
    144 modified don't have a significant follow-on effect on the overall 
    145 design of Django. If in doubt, ask. 
     140A "non-trivial" patch is one that is more than a simple bug fix. It's a patch 
     141that introduces Django functionality and makes some sort of design decision. 
     142 
     143If you provide a non-trivial patch, include evidence that alternatives have 
     144been discussed on `django-developers`_. If you're not sure whether your patch 
     145should be considered non-trivial, just ask. 
    146146 
    147147Ticket triage 
    …… 
    149149 
    150150Unfortunately, not all bug reports in the `ticket tracker`_ provide all  
    151 the `required details`_. Other tickets have patches, but those patches 
    152 do not meet all the requirements of a `good patch`_. 
    153  
    154 One way to help out is to triage bugs that have been reported by other users.  
     151the `required details`_. A number of tickets have patches, but those patches 
     152don't meet all the requirements of a `good patch`_. 
     153 
     154One way to help out is to *triage* bugs that have been reported by other users. 
    155155Pick an open ticket that is missing some details, and try to replicate the  
    156156problem. Fill in the missing pieces of the report. If the ticket doesn't have 
    157 a patch, create one.  
    158  
    159 Once you have completed all the missing details on the ticket and you have a 
    160 patch with all the required features, mail `django-developers`_. Indicate that  
    161 you have triaged a ticket, and recommend a course of action for dealing with 
    162 that ticket.  
    163  
    164 At first, this may require you to be persistent - if you find that your triaged 
    165 ticket still isn't getting attention, occasional polite requests for eyeballs to  
    166 look at your ticket may be necessary. However, as you earn a reputation for 
    167 quality triage work, you should find that it is easier to get the developers 
     157a patch, create one. 
     158 
     159Once you've completed all the missing details on the ticket and you have a 
     160patch with all the required features, e-mail `django-developers`_. Indicate 
     161that you have triaged a ticket, and recommend a course of action for dealing 
     162with that ticket.  
     163 
     164At first, this may require you to be persistent. If you find that your triaged 
     165ticket still isn't getting attention, occasional polite requests for eyeballs 
     166to look at your ticket may be necessary. However, as you earn a reputation for 
     167quality triage work, you should find that it is easier to get the developers' 
    168168attention. 
    169169