Django

Code

Changeset 3594

Show
Ignore:
Timestamp:
08/16/06 01:29:22 (2 years ago)
Author:
ubernostrum
Message:

0.90-fixes: Fixed minor security hole in compile-messages.py. See trunk patch in [3592]

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • django/branches/0.90-bugfixes/django/bin/compile-messages.py

    r1068 r3594  
    2020            sys.stderr.write('processing file %s in %s\n' % (file, dirpath)) 
    2121            pf = os.path.splitext(os.path.join(dirpath, file))[0] 
    22             cmd = 'msgfmt -o %s.mo %s.po' % (pf, pf) 
     22            # Store the names of the .mo and .po files in an environment 
     23            # variable, rather than doing a string replacement into the 
     24            # command, so that we can take advantage of shell quoting, to 
     25            # quote any malicious characters/escaping. 
     26            # See http://cyberelk.net/tim/articles/cmdline/ar01s02.html 
     27            os.environ['djangocompilemo'] = pf + '.mo' 
     28            os.environ['djangocompilepo'] = pf + '.po' 
     29            cmd = 'msgfmt -o "$djangocompilemo" "$djangocompilepo"' 
    2330            os.system(cmd) 
    2431