Django

Code

Changeset 3592

Show
Ignore:
Timestamp:
08/16/06 01:28:13 (2 years ago)
Author:
adrian
Message:

Fixed small security hole in bin/compile-messages.py by escaping the .po filename in os.system() call. Announcement forthcoming

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • django/trunk/django/bin/compile-messages.py

    r3590 r3592  
    2020                sys.stderr.write('processing file %s in %s\n' % (f, dirpath)) 
    2121                pf = os.path.splitext(os.path.join(dirpath, f))[0] 
    22                 cmd = 'msgfmt -o "%s.mo" "%s.po"' % (pf, pf) 
     22                # Store the names of the .mo and .po files in an environment 
     23                # variable, rather than doing a string replacement into the 
     24                # command, so that we can take advantage of shell quoting, to 
     25                # quote any malicious characters/escaping. 
     26                # See http://cyberelk.net/tim/articles/cmdline/ar01s02.html 
     27                os.environ['djangocompilemo'] = pf + '.mo' 
     28                os.environ['djangocompilepo'] = pf + '.po' 
     29                cmd = 'msgfmt -o "$djangocompilemo" "$djangocompilepo"' 
    2330                os.system(cmd) 
    2431