Django

Code

Changeset 2686

Show
Ignore:
Timestamp:
04/12/06 08:19:45 (3 years ago)
Author:
adrian
Message:

magic-removal: Fixed #1624 -- Made small changes to parameters in executemany() in cursor implementations in MySQL and SQLite database backends

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • django/branches/magic-removal/django/db/backends/sqlite3/base.py

    r2581 r2686  
    6363    Django uses "format" style placeholders, but pysqlite2 uses "qmark" style. 
    6464    This fixes it -- but note that if you want to use a literal "%s" in a query, 
    65     you'll need to use "%%s" (which I belive is true of other wrappers as well). 
     65    you'll need to use "%%s". 
    6666    """ 
    67  
    68     def execute(self, query, params=[]): 
     67    def execute(self, query, params=()): 
    6968        query = self.convert_query(query, len(params)) 
    7069        return Database.Cursor.execute(self, query, params) 
    7170 
    72     def executemany(self, query, params=[]): 
    73         query = self.convert_query(query, len(params[0])) 
     71    def executemany(self, query, param_list): 
     72        query = self.convert_query(query, len(param_list[0])) 
    7473        return Database.Cursor.executemany(self, query, params) 
    7574 

  • django/branches/magic-removal/django/db/backends/util.py

    r2501 r2686  
    77        self.db = db 
    88 
    9     def execute(self, sql, params=[]): 
     9    def execute(self, sql, params=()): 
    1010        start = time() 
    1111        try: