Ticket #5361: filestorage.3.diff

django/db/models/base.py

@@ -18 +18 @@
-import types
-import sys
-import os
+from warnings import warn
-
-class ModelBase(type):
-    "Metaclass for all models"
@@ -359 +360 @@
-        return getattr(self, cachename)
-
-    def _get_FIELD_filename(self, field):
-
-
-
+
+
-
-    def _get_FIELD_url(self, field):
-
-
-
-
+
+
-
-    def _get_FIELD_size(self, field):
-
+
+
-
-    def _save_FIELD_file(self, field, filename, raw_contents, save=True):
-
-
-
-
-
-
+
+
-
-        # If the filename already exists, keep adding an underscore to the name of
-        # the file until the filename doesn't exist.
-        while os.path.exists(os.path.join(settings.MEDIA_ROOT, filename)):
-            try:
-                dot_index = filename.rindex('.')
-            except ValueError: # filename has no dot
-                filename += '_'
-            else:
-                filename = filename[:dot_index] + '_' + filename[dot_index:]
-
-        # Write the file to disk.
-        setattr(self, field.attname, filename)
-
-        full_filename = self._get_FIELD_filename(field)
-        fp = open(full_filename, 'wb')
-        fp.write(raw_contents)
-        fp.close()
-
-        # Save the width and/or height, if applicable.
-        if isinstance(field, ImageField) and (field.width_field or field.height_field):
-            from django.utils.images import get_image_dimensions
-            width, height = get_image_dimensions(full_filename)
-            if field.width_field:
-                setattr(self, field.width_field, width)
-            if field.height_field:
-                setattr(self, field.height_field, height)
-
-        # Save the object because it has changed unless save is False
-        if save:
-            self.save()
-
-    _save_FIELD_file.alters_data = True
-
-    def _get_FIELD_width(self, field):
-
+
+
-
-    def _get_FIELD_height(self, field):
-
+
+
-
-    def _get_image_dimensions(self, field):
-        cachename = "__%s_dimensions_cache" % field.name
-        if not hasattr(self, cachename):
-            from django.utils.images import get_image_dimensions
-            filename = self._get_FIELD_filename(field)
-            setattr(self, cachename, get_image_dimensions(filename))
-        return getattr(self, cachename)
-
-############################################
-# HELPER FUNCTIONS (CURRIED MODEL METHODS) #
-############################################

django/db/models/fields/__init__.py

@@ +1 @@
+
-import datetime
-import os
-import time
@@ -704 +705 @@
-        defaults.update(kwargs)
-        return super(EmailField, self).formfield(**defaults)
-
+class File(object):
+    def __init__(self, obj, field, filename):
+        self.obj = obj
+        self.field = field
+        self.backend = field.backend
+        self.filename = filename
+
+    def __str__(self):
+        return self.backend.get_filename(self.filename)
+
+    def get_absolute_url(self):
+        return self.backend.get_absolute_url(self.filename)
+
+    def get_filesize(self):
+        if not hasattr(self, '_filesize'):
+            self._filesize = self.backend.get_filesize(self.filename)
+        return self._filesize
+
+    def open(self, mode='rb'):
+        return self.backend.open(self.filename, mode)
+
+    def save_file(self, filename, raw_contents, save=True):
+        self.filename = self.backend.save_file(filename, raw_contents)
+
+        # Update the filesize cache
+        self._filesize = len(raw_contents)
+
+        # Save the object because it has changed, unless save is False
+        if save:
+            self.obj.save()
+
+class FileProxy(object):
+    def __init__(self, field):
+        self.field = field
+        self.cache_name = self.field.get_cache_name()
+
+    def __get__(self, instance=None, owner=None):
+        if instance is None:
+            raise AttributeError, "%s can only be accessed from %s instances." % (self.field.attname, self.owner.__name__)
+        return getattr(instance, self.cache_name)
+
+    def __set__(self, instance, value):
+        if hasattr(instance, self.cache_name):
+            raise AttributeError, "%s can not be set in this manner." % self.field.attname
+        instance.__dict__[self.field.attname] = value
+        attr = self.field.attr_class(instance, self.field, value)
+        setattr(instance, self.cache_name, attr)
+
-class FileField(Field):
-
-
+
+
+
+
+
+
+
-        Field.__init__(self, verbose_name, name, **kwargs)
-
-    def get_db_prep_save(self, value):
@@ -714 +768 @@
-        # Need to convert UploadedFile objects provided via a form to unicode for database insertion
-        if value is None:
-            return None
-
+.filename
-
-    def get_manipulator_fields(self, opts, manipulator, change, name_prefix='', rel=False, follow=True):
-        field_list = Field.get_manipulator_fields(self, opts, manipulator, change, name_prefix, rel, follow)
@@ -754 +808 @@
-
-    def contribute_to_class(self, cls, name):
-        super(FileField, self).contribute_to_class(cls, name)
+        setattr(cls, self.attname, FileProxy(self))
-        setattr(cls, 'get_%s_filename' % self.name, curry(cls._get_FIELD_filename, field=self))
-        setattr(cls, 'get_%s_url' % self.name, curry(cls._get_FIELD_url, field=self))
-        setattr(cls, 'get_%s_size' % self.name, curry(cls._get_FIELD_size, field=self))
-        setattr(cls, 'save_%s_file' % self.name, lambda instance, filename, raw_contents, save=True: instance._save_FIELD_file(self, filename, raw_contents, save))
-        dispatcher.connect(self.delete_file, signal=signals.post_delete, sender=cls)
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
-
-    def get_manipulator_field_objs(self):
-        return [oldforms.FileUploadField, oldforms.HiddenField]
@@ -778 +831 @@
-    def save_file(self, new_data, new_object, original_object, change, rel, save=True):
-        upload_field_name = self.get_manipulator_field_names('')[0]
-        if new_data.get(upload_field_name, False):
-            func = getattr(new_object, 'save_%s_file' % self.name)
-            if rel:
-unc(new_data[upload_field_name][0]["filename"], new_data[upload_field_name][0]["content"], save)
+ield = new_data[upload_field_name][0]
-            else:
-
+
+
-
-    def get_directory_name(self):
-        return os.path.normpath(force_unicode(datetime.datetime.now().strftime(smart_str(self.upload_to))))
-
-    def get_filename(self, filename):
-        from django.utils.text import get_valid_filename
-        f = os.path.join(self.get_directory_name(), get_valid_filename(os.path.basename(filename)))
-        return os.path.normpath(f)
-
-    def save_form_data(self, instance, data):
-        if data:
-"save_%s_file" % self.name)(data.filename, data.content, save=False
+self.attname).save_file(data.filename, data.content
-
-    def formfield(self, **kwargs):
-        defaults = {'form_class': forms.FileField}
@@ -824 +869 @@
-        defaults.update(kwargs)
-        return super(FloatField, self).formfield(**defaults)
-
+class ImageFile(File):
+    def get_width(self):
+        return self._get_image_dimensions()[0]
+
+    def get_height(self):
+        return self._get_image_dimensions()[1]
+
+    def _get_image_dimensions(self):
+        if not hasattr(self, '_dimensions_cache'):
+            from django.utils.images import get_image_dimensions
+            self._dimensions_cache = get_image_dimensions(self.open())
+        return self._dimensions_cache
+
+    def save_file(self, filename, raw_contents):
+        super(ImageFile, self).save_file(filename, raw_contents)
+        
+        # Update the cache for image dimensions
+        from django.utils.images import get_image_dimensions
+        from cStringIO import StringIO
+        self._dimensions_cache = get_image_dimensions(StringIO(raw_contents))
+
-class ImageField(FileField):
+    attr_class = ImageFile
+
-    def __init__(self, verbose_name=None, name=None, width_field=None, height_field=None, **kwargs):
-        self.width_field, self.height_field = width_field, height_field
-        FileField.__init__(self, verbose_name, name, **kwargs)
@@ -842 +910 @@
-            setattr(cls, 'get_%s_height' % self.name, curry(cls._get_FIELD_height, field=self))
-
-    def save_file(self, new_data, new_object, original_object, change, rel, save=True):
-        FileField.save_file(self, new_data, new_object, original_object, change, rel, save)
-        # If the image has height and/or width field(s) and they haven't
-        # changed, set the width and/or height field(s) back to their original
-        # values.
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
-
+                upload_field_name = self.get_manipulator_field_names('')[0]
+                if rel:
+                    field = new_data[upload_field_name][0]
+                else:
+                    field = new_data[upload_field_name]
+
+                # Get the width and height from the raw content to avoid extra
+                # unnecessary trips to the file backend.
+                width, height = get_image_dimensions(StringIO(field["content"]))
+
+                if self.width_field:
+                    setattr(new_object, self.width_field, width)
+                if self.height_field:
+                    setattr(new_object, self.height_field, height)
+        FileField.save_file(self, new_data, new_object, original_object, change, rel, save)
+
-    def formfield(self, **kwargs):
-        defaults = {'form_class': forms.ImageField}
-        defaults.update(kwargs)

django/conf/global_settings.py

@@ -250 +250 @@
-from django import get_version
-URL_VALIDATOR_USER_AGENT = "Django/%s (http://www.djangoproject.com)" % get_version()
-
+# Default backend to use for saving FileFields
+DEFAULT_FILESTORAGE_BACKEND = 'django.core.filestorage.filesystem.FileSystemBackend'
+
+
-##############
-# MIDDLEWARE #
-##############

django/utils/images.py

@@ -6 +6 @@
-
-import ImageFile
-
-
- at a given
+file_or_
+, given an open file or a
-    p = ImageFile.Parser()
-
+
+
+
+
-    while 1:
-        data = fp.read(1024)
-        if not data:
@@ -19 +22 @@
-            return p.image.size
-            break
-    fp.close()
-
+

docs/db-api.txt

@@ -1851 +1851 @@
-get_FOO_filename()
-------------------
-
+**Deprecated in Django development version. See `managing files` for the new,
+preferred method for dealing with files.**
+
-For every ``FileField``, the object will have a ``get_FOO_filename()`` method,
-where ``FOO`` is the name of the field. This returns the full filesystem path
-to the file, according to your ``MEDIA_ROOT`` setting.
@@ -1861 +1864 @@
-get_FOO_url()
--------------
-
+**Deprecated in Django development version. See `managing files` for the new,
+preferred method for dealing with files.**
+
-For every ``FileField``, the object will have a ``get_FOO_url()`` method,
-where ``FOO`` is the name of the field. This returns the full URL to the file,
-according to your ``MEDIA_URL`` setting. If the value is blank, this method
@@ -1869 +1875 @@
-get_FOO_size()
---------------
-
+**Deprecated in Django development version. See `managing files` for the new,
+preferred method for dealing with files.**
+
-For every ``FileField``, the object will have a ``get_FOO_size()`` method,
-where ``FOO`` is the name of the field. This returns the size of the file, in
-bytes. (Behind the scenes, it uses ``os.path.getsize``.)
@@ -1876 +1885 @@
-save_FOO_file(filename, raw_contents)
--------------------------------------
-
+**Deprecated in Django development version. See `managing files` for the new,
+preferred method for dealing with files.**
+
-For every ``FileField``, the object will have a ``save_FOO_file()`` method,
-where ``FOO`` is the name of the field. This saves the given file to the
-filesystem, using the given filename. If a file with the given filename already
@@ -1885 +1897 @@
-get_FOO_height() and get_FOO_width()
-------------------------------------
-
+**Deprecated in Django development version. See `managing files` for the new,
+preferred method for dealing with files.**
+
-For every ``ImageField``, the object will have ``get_FOO_height()`` and
-``get_FOO_width()`` methods, where ``FOO`` is the name of the field. This
-returns the height (or width) of the image, as an integer, in pixels.

docs/model-api.txt

@@ -229 +229 @@
-``FileField``
-~~~~~~~~~~~~~
-
-Has one **required** argument
+**Requires** exactly one of the following two arguments
-
-    ======================  ===================================================
-    Argument                Description
-    ======================  ===================================================
-    ``upload_to``           A local filesystem path that will be appended to
-                            your ``MEDIA_ROOT`` setting to determine the
-
-
+
+
+
+
+
+
+
+
-    ======================  ===================================================
-
-
-
-
+
-
+The ``upload_to`` path may contain `strftime formatting`_, which will be
+replaced by the date/time of the file upload (so that uploaded files don't fill
+up the given directory).
+
-The admin represents this field as an ``<input type="file">`` (a file-upload
-widget).
-
-takes a few
-
+without a
+pecified backend takes a few s
-
-    1. In your settings file, you'll need to define ``MEDIA_ROOT`` as the
-       full path to a directory where you'd like Django to store uploaded