Ticket #3871: 3871-patch-with-docs.diff

django/db/models/fields/related.py

@@ -7 +7 @@
 from django.db.models.query import QuerySet
 from django.db.models.query_utils import QueryWrapper
 from django.db.models.deletion import CASCADE
+from django.db.models.manager import ManagerDescriptor
 from django.utils.encoding import smart_unicode
 from django.utils.translation import ugettext_lazy as _, string_concat
 from django.utils.functional import curry
@@ -386 +387 @@
         if instance is None:
             return self
 
-        return self.create_manager(instance,
+        def _other_fk_managers(manager):
+            """
+            Selects a manager from the list of the model's managers, useful
+            in the case of choosing a manager which is not the default, in a reverse relation.
+            """
+            if manager in self.related.model.__dict__ and isinstance(self.related.model.__dict__.get(manager, None), ManagerDescriptor):
+                return self.create_manager(instance, self.related.model.__dict__.get(manager).manager.__class__)
+            else:
+                raise AttributeError("Manager %s does not exist" % manager)
+
+        manager = self.create_manager(instance,
                 self.related.model._default_manager.__class__)
+        manager.managers = _other_fk_managers
+        return manager
 
     def __set__(self, instance, value):
         if instance is None:
@@ -671 +684 @@
         # model's default manager.
         rel_model = self.related.model
         superclass = rel_model._default_manager.__class__
+
         RelatedManager = create_many_related_manager(superclass, self.related.field.rel)
 
         manager = RelatedManager(
@@ -684 +698 @@
             through=self.related.field.rel.through,
         )
 
+        def _other_m2m_managers(manager):
+            """
+            Selects a manager from the list of the model's managers, useful
+            in the case of choosing a manager which is not the default, in a reverse relation.
+            """
+            if manager in self.related.model.__dict__ and isinstance(self.related.model.__dict__.get(manager, None), ManagerDescriptor):
+                return self.create_many_related_manager(self.related.model.__dict__.get(manager).manager.__class__, self.related.field.rel)
+            else:
+                raise AttributeError("Manager %s does not exist" % manager)
+
+        manager.managers = _other_m2m_managers
         return manager
 
     def __set__(self, instance, value):

docs/topics/db/queries.txt

@@ -1036 +1036 @@
 the database. Every addition, creation and deletion is immediately and
 automatically saved to the database.
 
+The ``entry_set`` notation, returns the default ``Manager`` defined for the
+``Entry`` model, if you want to choose a custom manager, use the ``managers()``
+method of ``entry_set``. For example::
+
+    b = Blog.objects.get(id=1)
+    # Selects the custom_manager attribute, defined on Entry
+    b.entry_set.managers('custom_manager')
+
 .. _m2m-reverse-relationships:
 
 Many-to-many relationships
@@ -1062 +1070 @@
 Like ``ForeignKey``, ``ManyToManyField`` can specify ``related_name``. In the
 above example, if the ``ManyToManyField`` in ``Entry`` had specified
 ``related_name='entries'``, then each ``Author`` instance would have an
-``entries`` attribute instead of ``entry_set``.
+``entries`` attribute instead of ``entry_set``. The ``entries`` attribute, 
+also has a ``managers()`` method to select custom managers. For example::
+
+    b = Author.objects.get(id=5)
+    # Selects the custom_manager attribute, defined on Entry
+    b.entries.managers('custom_manager')
+
 
 One-to-one relationships
 ------------------------

tests/modeltests/custom_managers/models.py

@@ -50 +50 @@
 
 class Car(models.Model):
     name = models.CharField(max_length=10)
+    manufacturer = models.ForeignKey('Manufacturer')
     mileage = models.IntegerField()
     top_speed = models.IntegerField(help_text="In miles per hour.")
     cars = models.Manager()
@@ -57 +58 @@
 
     def __unicode__(self):
         return self.name
+
+class Manufacturer(models.Model):
+    name = models.CharField(max_length=10)
+    country = models.CharField(max_length=20)

tests/modeltests/custom_managers/tests.py

@@ -1 +1 @@
 from django.test import TestCase
 
-from models import Person, Book, Car, PersonManager, PublishedBookManager
+from models import Person, Book, Car, Manufacturer, PersonManager, PublishedBookManager
 
 
 class CustomManagerTests(TestCase):
@@ -40 +40 @@
             lambda b: b.title
         )
 
-        c1 = Car.cars.create(name="Corvette", mileage=21, top_speed=180)
-        c2 = Car.cars.create(name="Neon", mileage=31, top_speed=100)
+        chevy = Manufacturer.objects.create(name="Chevrolet", country="USA")
+        dodge = Manufacturer.objects.create(name="Dodge", country="USA")
+
+        c1 = Car.cars.create(name="Corvette", mileage=21, top_speed=180, manufacturer=chevy)
+        c2 = Car.cars.create(name="Neon", mileage=31, top_speed=100, manufacturer=dodge)
+        c3 = Car.cars.create(name="Viper", mileage=14, top_speed=200, manufacturer=dodge)
 
         self.assertQuerysetEqual(
             Car.cars.order_by("name"), [
                 "Corvette",
                 "Neon",
+                "Viper"
             ],
             lambda c: c.name
         )
@@ -54 +59 @@
         self.assertQuerysetEqual(
             Car.fast_cars.all(), [
                 "Corvette",
+                "Viper",
             ],
             lambda c: c.name
         )
@@ -66 +72 @@
             Car._default_manager.order_by("name"), [
                 "Corvette",
                 "Neon",
+                "Viper",
+            ],
+            lambda c: c.name
+        )
+
+        #Choosing a custom manager in a reverse relation
+        self.assertQuerysetEqual(
+            dodge.car_set.managers('fast_cars').all(), [
+                "Viper",
             ],
             lambda c: c.name
         )