Ticket #3389: m2m_ids.diff

django/db/models/fields/related.py

@@ -316 +316 @@
-            # join_table: name of the m2m link table
-            # source_col_name: the PK colname in join_table for the source object
-            # target_col_name: the PK colname in join_table for the target object
-
+. Either object instances, or primary keys of object instances.
-            from django.db import connection
-
-            # If there aren't any objects, there is nothing to do.
-            if objs:
-                # Check that all the objects are of the right type
+                new_ids = set()
-                for obj in objs:
-
-
+
+
+
+
-                # Add the newly created or already existing objects to the join table.
-                # First find out which items are already added, to avoid adding them twice
-                new_ids = set([obj._get_pk_val() for obj in objs])
-                cursor = connection.cursor()
-                cursor.execute("SELECT %s FROM %s WHERE %s = %%s AND %s IN (%s)" % \
-                    (target_col_name, self.join_table, source_col_name,
@@ -354 +356 @@
-            # If there aren't any objects, there is nothing to do.
-            if objs:
-                # Check that all the objects are of the right type
+                old_ids = set()
-                for obj in objs:
-
-
+
+
+
+
-                # Remove the specified objects from the join table
-                old_ids = set([obj._get_pk_val() for obj in objs])
-                cursor = connection.cursor()
-                cursor.execute("DELETE FROM %s WHERE %s = %%s AND %s IN (%s)" % \
-                    (self.join_table, source_col_name,

tests/modeltests/many_to_many/models.py

@@ -203 +203 @@
->>> p2.article_set.all()
-[<Article: Oxygen-free diet works wonders>]
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
->>> p1 = Publication(id=None, title='The Python Journal')
->>> p1.save()
->>> a2 = Article(id=None, headline='NASA uses Python')