Ticket #17988: test_model_formset_checks_commit_before_delete.diff

tests/regressiontests/inline_formsets/tests.py

@@ -108 +108 @@
             obj.save()
         self.assertEqual(school.child_set.count(), 1)
 
+    def test_deletion_without_commit(self):
+        """
+        Make sure inlineformsets respect commit=False when deleting (#17988).
+        """
+        PoemFormSet = inlineformset_factory(Poet, Poem, can_delete=True)
+        poet = Poet.objects.create(name='test')
+        poem = poet.poem_set.create(name='test poem')
+        data = {
+            'poem_set-TOTAL_FORMS': u'1',
+            'poem_set-INITIAL_FORMS': u'1',
+            'poem_set-MAX_NUM_FORMS': u'0',
+            'poem_set-0-id': unicode(poem.pk),
+            'poem_set-0-poet': unicode(poet.pk),
+            'poem_set-0-name': u'test',
+        }
+        formset = PoemFormSet(data, instance=poet)
+        self.assertTrue(formset.is_valid())
+        formset.save()
+        self.assertEqual(Poem.objects.count(), 1)
 
+        data['poem_set-0-DELETE'] = 'on'
+        formset = PoemFormSet(data, instance=poet)
+        self.assertTrue(formset.is_valid())
+
+        poems = formset.save(commit=False)
+        self.assertEqual(poems, [])
+        self.assertEqual(len(formset.deleted_objects), 1)
+        self.assertEqual(Poem.objects.count(), 1)
+
+        poems = formset.save()
+        self.assertEqual(poems, [])
+        self.assertEqual(len(formset.deleted_objects), 1)
+        self.assertEqual(Poem.objects.count(), 0)
+
+
 class InlineFormsetFactoryTest(TestCase):
     def test_inline_formset_factory(self):
         """