Ticket #12151: 12151_2.diff

django/contrib/comments/views/utils.py

@@ -39 +39 @@
         if 'c' in request.GET:
             try:
                 comment = comments.get_model().objects.get(pk=request.GET['c'])
-            except ObjectDoesNotExist:
+            except (ObjectDoesNotExist, ValueError):
                 pass
         return render_to_response(template,
             {'comment': comment},

tests/regressiontests/comment_tests/tests/comment_view_tests.py

@@ -219 +219 @@
         location = response["Location"]        
         match = re.search(r"^http://testserver/somewhere/else/\?foo=bar&c=\d+$", location)
         self.failUnless(match != None, "Unexpected redirect location: %s" % location)
-        
- No newline at end of file
+
+    def testCommentDoneReSubmitWithInvalidParams(self):
+        """
+        If the comment-done url is resubmitted with some invalid data
+        ie mainly some non-integer, then a UnicodeEncodeError (a sub-class 
+        of ValueError).
+        """
+        a = Article.objects.get(pk=1)
+        data = self.getValidData(a)
+        data["comment"] = "This is another comment"
+        response = self.client.post("/post/", data)
+        location = response["Location"]
+        new_location = location + u"\ufffd"
+        x = lambda : self.client.get(new_location)
+        try:
+            self.assertRaises(ValueError, x)
+        except AssertionError:
+            # An exception shouldn't be raised. 
+            # Hope there was a assertNotRaises
+            pass